Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ionex: migrate from interp2d to RegularGridInterpolator #1223

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Jun 25, 2024

Description of proposed changes

  • objects.ionex.get_ionex_value(): migrate from scipy.interpolate.interp2d() to scipy.interpolate.RegularGridInterpolator(), as the former has been removed since scipy-1.14.

  • tests.objects.ionex.py: more print out msg

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI unit test (the circleci integration test is failing due to the known gdal issue Cannot import gdal in circle CI testing #1220)
  • Pass local integration test
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ objects.ionex.get_ionex_value(): migrate from scipy.interpolate.interp2d() to scipy.interpolate.RegularGridInterpolator(), as the former has been removed since scipy-1.14

+ tests.objects.ionex.py: more print out msg
@yunjunz yunjunz merged commit fa52232 into insarlab:main Jun 25, 2024
6 of 7 checks passed
@yunjunz yunjunz deleted the ionex_interp branch June 25, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant