-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add HDF-EOS5 metadata for HyP3 products #1180
Conversation
@yunjunz not sure I got |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @forrestfwilliams, start/stopUTC should come from the same acquisition, so the current calculation should be fine.
However, we would also need the ascending note time of the same acquisition to calculate the ASF frame number for S1. I guess that could be added later in the HyP3 metadata? Regardless, we could merge this PR without this extra attribute.
My misunderstanding: the |
+ update relative_orbit calc for S1A/B + update start/stopUTC calc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks all good to me now. Thank you @forrestfwilliams.
Update: beam_swath is needed for hyp3-gamma/isce2 products. I will push another commit here.
Sounds good! Do we need to update |
They are fixed now. |
Description of proposed changes
At @yunjunz's suggestion, this PR adds the
startUTC
,stopUTC
, andrelativeOrbit
fields to HyP3-derived products to support HDF-EOS5 conversion.Reminders
hyp3
: more metadata forHDF-EOS5
support #1162