Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

view.prep_slice(): support quoted lists of characters as inputs #1077

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 23, 2023

Description of proposed changes

  • view.prep_slice(): support quoted lists of characters as inputs so that its parsing behavior is the same as the one in command line

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

so that its parsing behavior is the same as the on in command line
@yunjunz yunjunz merged commit f068ec5 into insarlab:main Aug 23, 2023
7 checks passed
@yunjunz yunjunz deleted the prep_slice branch August 23, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant