Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

seq. closure phase: bring back spatial referencing for ARIA products #1063

Merged
merged 2 commits into from
Aug 9, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented Aug 8, 2023

Description of proposed changes

This PR brings back the spatial referencing while calculating the sequential closure phase (which was removed in #922), for ARIA products only, to avoid the abnormal closure phase calculation result, as shown below. This is happening to ARIA products only, there is negligible impact on the interferogram stack processed with ISCE-2 from SLC (as @yjzhenglamarmota and I have tested before).

My guess is that the phase stitching applied during ARIA product preparation in ARIA-tools broke the temporal consistency of the native unwrapped phase (when used without spatial referencing). What do you think @sssangha @mgovorcin @dbekaert?

San Francisco Bay SenDT042 (downloaded from ARIA and processed with ARIA-tools)

  • Without spatial referencing
Screenshot 2023-08-08 at 13 55 17
  • With spatial referencing
Screenshot 2023-08-08 at 13 55 07

Sierra Negra SenDT128 dataset (processed with isce2/topsStack)

  • Without spatial referencing
Screenshot 2023-08-08 at 14 25 18
  • With spatial referencing
Screenshot 2023-08-08 at 14 25 27

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.

+ objects.stack.ifgramStack.get_sequential_closure_phase(): bring back the spatial referencing to ARIA products, to avoid the abnormal closure phase calculation result, which is likely due to the phase stitching applied during ARIA products preparation in ARIA-tools.
@yunjunz yunjunz changed the title get_sequential_closure_phase: bring back spatial referencing for ARIA products sequential_closure_phase: bring back spatial referencing for ARIA products Aug 8, 2023
@yunjunz yunjunz changed the title sequential_closure_phase: bring back spatial referencing for ARIA products seq. closure phase: bring back spatial referencing for ARIA products Aug 8, 2023
Copy link
Contributor

@yjzhenglamarmota yjzhenglamarmota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. The amplitude for the ARIA test case is clearly wrong, though the phase looks surprisingly coherent. I agree it might be related to filtering that breaks the temporal consistency.

@yunjunz yunjunz merged commit 6605a95 into insarlab:main Aug 9, 2023
5 of 6 checks passed
@yunjunz yunjunz deleted the closure_phase branch August 9, 2023 01:31
@mgovorcin
Copy link
Contributor

@yunjunz did you run reference_point.py before this?

My guess is that GUNW ifgs might have different unwrapping seed point between pairs (this will especially change during stitching process) as coregistration is not done to the same reference image. The requirement would be to do spatial referencing before any further processing on them.

We do not do re-referencing of all ifgs to common reference point during prep_aria as that is done during reference_point step in the smallbaseline workflow. @sssangha might be good to add this to avoid potential misuse, what do you think?

@yunjunz
Copy link
Member Author

yunjunz commented Aug 12, 2023

@mgovorcin The first figure is without running reference_point.py.

Rethinking about this, I don't think the different seeding points or phase stitching would introduce this, because neither of them will change the wrapped phase value, which is what this figure is really using. The different reference images during pair-wise coregistration, as used in ARIA, sound more likely, as inconsistent range shifts are applied to both the resampling and SLC phase component, thus, could introduce this temporal inconsistency. Do you agree @hfattahi and @piyushrpt?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants