Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

diff: support unw/off - timeseries #1011

Merged
merged 1 commit into from
May 24, 2023
Merged

diff: support unw/off - timeseries #1011

merged 1 commit into from
May 24, 2023

Conversation

yunjunz
Copy link
Member

@yunjunz yunjunz commented May 24, 2023

Description of proposed changes

  • diff.py:

    • support the differencing between a *.unw (or offset file with FILE_TYPE of displacement) file and a time-series file, as used frequently in phase correction procedures, by adding a sub-function diff_ifgram_and_timeseries()
    • split diff_timeseries() and diff_ifgram_stack() out of diff_file() for clarity.
    • prepare isce metadata file, to be consistent with mask.py and subset.py
  • call diff.py to handle the correction procedure in the following scripts:

    • iono_tec.py
    • legacy/tropo_pyaps.py
    • solid_earth_tides.py
    • tropo_gacos.py
    • tropo_pyaps3.py
  • cli/geocode.py: if --lat-file is specified, honor this manually set file as the default lookupFile, rather than searching for the default file patterns, which could be NOT consistent with input files.

Reminders

  • Pass Pre-commit check (green)
  • Pass Codacy code review (green)
  • Pass Circle CI test (green)
  • Make sure that your code follows our style. Use the other functions/files as a basis.
  • If modifying functionality, describe changes to function behavior and arguments in a comment below the function declaration.
  • If adding new functionality, add a detailed description to the documentation and/or an example.

+ diff.py:
   - support the differencing between an *.unw (or offset file with FILE_TYPE of displacement) file and a time-series file, as used frequently in phase correction procedures, by adding a sub-function `diff_ifgram_and_timeseries()`
   - split diff_timeseries() and diff_ifgram_stack() out of diff_file() for clarity.
   - prepare isce metadata file, to be consistent with mask.py and subset.py

+ call diff.py to handle the correction procesure in the following scripts:
   - iono_tec.py
   - legacy/tropo_pyaps.py
   - solid_earth_tides.py
   - tropo_gacos.py
   - tropo_pyaps3.py

+ cli/geocode.py: if --lat-file is specified, honor this manually specified file as the default lookupFile, rather than searching for the default file patterns, which is could be NOT consistent with input files.
@yunjunz yunjunz merged commit 6cbbf29 into insarlab:main May 24, 2023
@yunjunz yunjunz deleted the diff branch May 24, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant