Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing writeTMVar to MonadSTM #155

Merged
merged 3 commits into from
May 13, 2024
Merged

Add missing writeTMVar to MonadSTM #155

merged 3 commits into from
May 13, 2024

Conversation

nitinprakash96
Copy link
Contributor

Should close #152

@bolt12
Copy link
Contributor

bolt12 commented May 10, 2024

Thanks! Please make sure to update the Changelog as well!

@nitinprakash96
Copy link
Contributor Author

This is also going to need MIN_VERSION macros since writeTMVar was introduced in 2.5.1
Good thing CI caught that.

@bolt12
Copy link
Contributor

bolt12 commented May 13, 2024

Changelog for io-sim is missing 😄

bolt12
bolt12 approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks!!

@bolt12 bolt12 added this pull request to the merge queue May 13, 2024
Merged via the queue into input-output-hk:main with commit 434f33a May 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bolt12 bolt12 bolt12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add writeTMVar to MonadSTM
2 participants
@nitinprakash96 @bolt12