Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored package structure: use sublibraries #115

Merged
merged 4 commits into from
Aug 26, 2024
Merged

Refactored package structure: use sublibraries #115

merged 4 commits into from
Aug 26, 2024

Conversation

coot
Copy link
Collaborator

@coot coot commented Sep 28, 2023

Put si-timers, strict-stm and strict-mvar as public libraries of io-classes.

strict-mvar:test is left in test-strict-mvar as it introduces
a cycle between io-sim and io-classes which cabal cannot resolve.

@coot coot marked this pull request as draft September 28, 2023 13:11
@coot coot changed the title Refactor package strcuture Refactor package structure Sep 28, 2023
@coot coot force-pushed the coot/io-classes branch 4 times, most recently from 3e9279e to ae78bbd Compare September 28, 2023 17:44
@coot coot marked this pull request as ready for review October 11, 2023 14:59
@coot coot force-pushed the coot/io-classes branch 2 times, most recently from 79e55fe to a0faf60 Compare October 11, 2023 17:13
Copy link
Contributor

@bolt12 bolt12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, needs a changelog entry

@coot
Copy link
Collaborator Author

coot commented Oct 24, 2023

It would be nice to get cabal changes to the haddock-project command before we merge it. I looked into and it seems doable, although requires a bit of thinking to get all the parts right. Once new version of cabal is published we can use it to publish haddocks on Github Pages, until Hackage also supports public sub-libraries (which if I am lucky 😉 I will also fix in the same set of changes).

@jorisdral
Copy link
Contributor

jorisdral commented Feb 17, 2024

strict-mvar:test is left in test-strict-mvar as it introduces a cycle between io-sim and io-classes which cabal cannot resolve.

One alternative would be to split the tests, moving the ones for IO to io-classes, and the ones for IOSim to io-sim. The properties could be put in a separate sublib in io-classes so io-sim can reuse them

@coot
Copy link
Collaborator Author

coot commented Jul 1, 2024

@jorisdral done;

cabal PR haskell/cabal#9821 was merged, so with next cabal release we can merge it.

`strict-mvar:test` is left in `test-strict-mvar` as it introduces
a cycle between `io-sim` and `io-classes` which cabal cannot resolve.
Move `IO` tests to `io-classes` and `IOSim` tests to `io-sim`.
@coot coot added this pull request to the merge queue Aug 26, 2024
@coot coot changed the title Refactor package structure Refactored package structure: use sublibraries Aug 26, 2024
Merged via the queue into main with commit 032578f Aug 26, 2024
19 of 20 checks passed
@coot coot deleted the coot/io-classes branch August 26, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants