Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wasm): Add Hermes WASM APIs #74

Merged
merged 40 commits into from
Feb 6, 2024
Merged

feat(wasm): Add Hermes WASM APIs #74

merged 40 commits into from
Feb 6, 2024

Conversation

stevenj
Copy link
Collaborator

@stevenj stevenj commented Jan 30, 2024 •
edited
Loading

Description

  • Adds Milestone 1 WASI/Hermes WASM APIs
    • Also adds a number of APIs not in scope for milestone 1.
  • Adds basic documentation for these api's to the published gh-pages docs for the project
  • Adds code generation for Hermes for the .wit define dAPIs.
  • Adds stubs for all APIs.
  • Adds simple logic to create the state needed by the wasm executor for a module.

Related Issue(s)

Closes #82
Closes #83
Closes #86
Closes #87
Closes #91
Closes #92
Closes #96
Closes #97
Closes #100
Closes #102
Closes #104
Closes #105

Please confirm the following checks

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream module

@stevenj stevenj added the do not merge yet PR is not ready to be merged yet label Jan 30, 2024
@stevenj stevenj added this to the M2: Hermes Foundations milestone Jan 30, 2024
@stevenj stevenj self-assigned this Jan 30, 2024
Mr-Leshiy
Mr-Leshiy previously approved these changes Feb 1, 2024
View reviewed changes
Mr-Leshiy
Mr-Leshiy reviewed Feb 1, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@Mr-Leshiy Mr-Leshiy self-requested a review February 1, 2024 08:36
@stevenj stevenj added review me PR is ready for review and removed do not merge yet PR is not ready to be merged yet labels Feb 5, 2024
bkioshn
bkioshn reviewed Feb 5, 2024
View reviewed changes
docs/Earthfile Outdated Show resolved Hide resolved
hermes/bin/src/runtime/host/hermes/kv_store/mod.rs Show resolved Hide resolved
wasm/wasi/wit/deps/hermes-logging/api.wit Outdated Show resolved Hide resolved
Mr-Leshiy
Mr-Leshiy reviewed Feb 5, 2024
View reviewed changes
hermes/bin/src/runtime/extensions/mod.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime/extensions/mod.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime/host/mod.rs Outdated Show resolved Hide resolved
hermes/bin/src/runtime/extensions/mod.rs Show resolved Hide resolved
hermes/bin/src/runtime/extensions/mod.rs Show resolved Hide resolved
Mr-Leshiy
Mr-Leshiy previously approved these changes Feb 5, 2024
View reviewed changes
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

minikin
minikin previously requested changes Feb 5, 2024
View reviewed changes
hermes/bin/src/runtime/extensions/mod.rs Outdated Show resolved Hide resolved
saibatizoku
saibatizoku previously approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@saibatizoku saibatizoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj enabled auto-merge (squash) February 6, 2024 03:44
minikin
minikin approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevenj stevenj merged commit 652c060 into main Feb 6, 2024
20 checks passed
@stevenj stevenj deleted the feat/hermes-wasm-api-drafts branch February 6, 2024 08:52
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkioshn bkioshn bkioshn left review comments

@minikin minikin minikin approved these changes

@saibatizoku saibatizoku saibatizoku left review comments

@Mr-Leshiy Mr-Leshiy Mr-Leshiy left review comments

@FelipeRosa FelipeRosa Awaiting requested review from FelipeRosa FelipeRosa is a code owner

@cong-or cong-or Awaiting requested review from cong-or cong-or is a code owner

Assignees

@stevenj stevenj

Labels
review me PR is ready for review
Projects
Catalyst
Status: ✅ Done
Milestone
M2: Hermes Foundations
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Chronological Event utility API (Cron): Documented WASI API Definition 🛠️ [TASK] : Time utility API: Interface to WASM Runtime. 🛠️ [TASK] : Time utility API: Documented WASI API Definition 🛠️ [TASK] : Logging utility API: Interface to WASM Runtime. 🛠️ [TASK] : Logging utility API: Documented WASI API Definition
🛠️ [TASK] : Chronological Event utility API (Cron): Interface to WASM Runtime. 🛠️ [TASK] : Hashing utility API: Documented WASI API Definition 🛠️ [TASK] : Hashing utility API: Interface to WASM Runtime. 🛠️ [TASK] : Cryptography utility API: Documented WASI API Definition 🛠️ [TASK] : Cryptography utility API: Interface to WASM Runtime.
5 participants
@stevenj @saibatizoku @minikin @Mr-Leshiy @bkioshn