Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Hermes engine architecture design notes #62

Merged
merged 15 commits into from
Jan 24, 2024
Merged

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Jan 17, 2024

Description

Hermes engine architecture design notes.
Updated sections:

Related Issue(s)

Closes #59

Docs link

https://input-output-hk.github.io/hermes/branch/feat_hermes_arc/

@Mr-Leshiy Mr-Leshiy self-assigned this Jan 17, 2024
Copy link

@alicechaitea alicechaitea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@Mr-Leshiy Mr-Leshiy mentioned this pull request Jan 22, 2024
4 tasks
@minikin minikin added the review me PR is ready for review label Jan 22, 2024
cong-or
cong-or previously approved these changes Jan 22, 2024
Copy link
Contributor

@cong-or cong-or left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Mr-Leshiy Mr-Leshiy added the do not merge yet PR is not ready to be merged yet label Jan 23, 2024
@Mr-Leshiy
Copy link
Contributor Author

don't merge this PR

* docs(docs): Reorganize to simplify parallel contributions

* docs(docs): Remove redundant .svg image files

* docs(spelling): add excalidraw as a known project word

* fix hermes_core image rendering

---------

Co-authored-by: Mr-Leshiy <leshiy12345678@gmail.com>
Copy link
Collaborator

@stevenj stevenj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The whole architecture is still WIP.
So, I am happy with this PR as is as a starting point.
We will be making subsequent revisions and trying to keep it DRY to make maintenance simpler.

@Mr-Leshiy Mr-Leshiy merged commit 5ceca8c into main Jan 24, 2024
11 checks passed
@Mr-Leshiy Mr-Leshiy deleted the feat/hermes-arc branch January 24, 2024 13:48
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge yet PR is not ready to be merged yet review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🛠️ [TASK] : Low level doc for hermes engine mechanics
5 participants