Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add more tests for module packaging module #315

Merged
merged 28 commits into from
Aug 1, 2024
Merged

Conversation

Mr-Leshiy
Copy link
Contributor

@Mr-Leshiy Mr-Leshiy commented Aug 1, 2024

Description

Added more tests and updated existing one for the hermes module packaging module

Related Issue(s)

#129

Description of Changes

  • Moved tests into the separate file tests.rs.
  • Added share directory creation and usage during module packaging tests.
  • Added corrupted_metadata_test, corrupted_component_test, corrupted_config_test, corrupted_config_schema_test, corrupted_settings_schema_test, corrupted_share_dir_test.
  • Refactored ResourceBuilder::Fs

@Mr-Leshiy Mr-Leshiy self-assigned this Aug 1, 2024
@Mr-Leshiy Mr-Leshiy added the review me PR is ready for review label Aug 1, 2024
Copy link
Collaborator

@minikin minikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@minikin minikin merged commit a53a17d into main Aug 1, 2024
37 checks passed
@minikin minikin deleted the test/wasm-module branch August 1, 2024 13:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
review me PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants