feat(cardano-chain-follower): Overhead benchmark implementations (pallas + cardano-chain-follower) #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… + cardano-chain-follower) Co-authored-by: Joaquín Rosales <joaquin.rosales@iohk.io>
FelipeRosa
requested review from
stevenj,
Mr-Leshiy,
cong-or,
saibatizoku and
minikin
as code owners
…output improvements
…mes crates conventions
FelipeRosa
changed the title
FelipeRosa
force-pushed
the
feat/cardano-chain-follower-benchmark
branch
4 times, most recently
from
77894da
to
907b710
Compare
FelipeRosa
force-pushed
the
feat/cardano-chain-follower-benchmark
branch
from
907b710
to
19db54f
Compare
…follower overhead benchmark
FelipeRosa
force-pushed
the
feat/cardano-chain-follower-benchmark
branch
from
19db54f
to
a4ace8c
Compare
minikin
approved these changes
Apr 23, 2024
There was a problem hiding this comment.
LGTM
@FelipeRosa We need to consider publishing benchmark results in the future.
What do you think?
I agree. We need to define how we are going to do that because running the benchmarks also involves downloading/storing Mithril snapshots which, for mainnet specially, can be big. Maybe we want to consider triggering them manually or nightly (something like that). |
|
task to publish results #217 |
8 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
NOTE:
This replaces #206. I have added @saibatizoku as a co-author in the commits as his draft PR served as inspiration for this.
This PR implements a benchmark to measure the overhead that the internal implementation of the
cardano-chain-followerhas in comparison to using the pallas library directly to read a Mithril snapshot.Related Issues
Closes #201.