fix: drop alternative clicks (close #241)

inpageedit · Jan 4, 2024 · 73a5b46 · 73a5b46
1 parent 6aa44d2
commit 73a5b46
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/src/module/loadQuickDiff.js b/src/module/loadQuickDiff.js
@@ -3,6 +3,7 @@ import { _analytics } from './_analytics'
 import { quickDiff } from './quickDiff'
 import { quickEdit } from './quickEdit'
 import { mwConfig } from './mw'
+import { isAlternativeClick } from '../utils/alternativeClick'
 const { getParamValue } = mw.util
 
 function injectLinks(container) {
@@ -87,6 +88,7 @@ function injectLinks(container) {
 
       // 点击事件
       $this.on('click', function (e) {
+        if (isAlternativeClick(e)) return
         e.preventDefault()
         _analytics('quick_diff_recentchanges')
         return quickDiff(params)
@@ -108,9 +110,7 @@ export function loadQuickDiff(container) {
       $('<button>')
         .text(_msg('quick-diff'))
         .on('click', function (e) {
-          if (e.ctrlKey || e.altKey || e.shiftKey || e.metaKey) {
-            return
-          }
+          if (isAlternativeClick(e)) return
 
           e.preventDefault()
           _analytics('quick_diff_history_page')

diff --git a/src/utils/alternativeClick.js b/src/utils/alternativeClick.js
@@ -0,0 +1,8 @@
+/**
+ * @param {MouseEvent} e
+ * @returns {boolean}
+ */
+export const isAlternativeClick = (e) => {
+  const event = e.originalEvent || e
+  return event.altKey || event.ctrlKey || event.metaKey || event.shiftKey
+}