Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add onCompleteCallback option #303

Merged
merged 5 commits into from
Mar 1, 2023
Merged

Add onCompleteCallback option #303

merged 5 commits into from
Mar 1, 2023

Conversation

inorganik
Copy link
Owner

I'm submitting a...

[ ] Bug Fix
[x ] Feature
[ ] Other (Refactoring, Added tests, Documentation, ...)

Checklist

  • [ x] Test your changes
  • Followed the build steps

Description

Adds a new option onCompleteCallback to the options object which will get called on completion of the animation. For backwards compatibility (and convenience), if a callback is passed to the start method, it will replace whatever was set in the options.

Also updated the demo and added several tests

Does this PR introduce a breaking change?

[ ] Yes
[ x] No

@inorganik
Copy link
Owner Author

Resolves #302

@inorganik inorganik merged commit c12680a into master Mar 1, 2023
@inorganik inorganik deleted the callback-on-scrollspy branch March 1, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant