collection hierarchies #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
March 3, 2011 09:27
for now, this replaces the alphabetical view; there doesn't seem to be much value in retaining that as a separate option - especially because all collections are displayed at the root level anyway implementation largely cargo-culted from hierarchical concepts (though much of concepts' complexity does not apply here - yay simplicity) there's some potential for DRY-related refactoring; a utility function might generate treeview markup for lists of both concepts and collections
in order to avoid redundancies only orphans - i.e. collections without a parent collection - should appear at the root level the current implementation seems rather brute-force, i.e. inefficient and inelegant - there might be a better way NB: Circular references (e.g. foo contains bar, bar contains foo) result in the respective collections not being displayed at all, rendering them inaccessible (unless they have a separate relationship to an orphan). This was deemed a data-entry issue, thus not relevant here.
|
updated (6bedf4f) after discussion with tb |
wvk
added a commit
that referenced
this pull request
May 15, 2013
Fix login test and changed database cleaner strategy.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as discussed with tb
Ideally, this sort of thing should have tests - perhaps some pairing would make sense to get me started?