accessible hierarchies #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burying hierarchical_concepts_path call in an attribute value made it very hard to read, so caching the value in a variable instead not entirely sure this is the best solution though
s/furter/further/g
instead of loading and rendering the entire tree via JavaScript, we render root-level items on the server side - due to related concepts being linked, this allows user agents to traverse the tree without client-side processing code largely adapted from hierarchical index template (minus broader relations); eventually that template should also use this partial (DRY) behavior seems the same as before, except that order is not necessarily the same; unsure why this is the case or whether it is significant plus minor whitespace fixes
per definition, this view only renders root-level items - so those should not have any broader relations
passing a list of concepts into the helper should enable us to reuse this partial for the hierarchical index view
reduced line lengths, fixed whitespace and ERb tags
this eliminates remaining redundancies, taking advantage of previously improved encapsulation
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improved accessibility by ensuring hierarchies' root level is rendered server-side
a thorough review would be appreciated to ensure I'm not being naive/ignorant or breaking conventions