Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using downcase for query terms prevents search results for Umlaute #351

Closed
fabianzwodrei opened this issue Dec 15, 2015 · 2 comments
Closed

Using downcase for query terms prevents search results for Umlaute #351

fabianzwodrei opened this issue Dec 15, 2015 · 2 comments
Assignees
@mjansing
Labels
bug

Comments

@fabianzwodrei
Copy link

Most searches iQvoc won't bring up labels with values like "Ägypten" because the .downcase function won't make it a lowercase string.

"Ägypten".downcase => "Ägypten" which is a problem for the sql LOWER(label.value) function that is used for searching. Searching for "Ägypten" will never find "Ägypten" – whereas 'ägypten' will find 'Ägypten' in the DB.
@mjansing mjansing added the bug label Apr 29, 2016
@mjansing
Copy link
Contributor

see also #355.

@mjansing mjansing self-assigned this Apr 29, 2016
mjansing added a commit that referenced this issue Apr 29, 2016
@mjansing
fix search if term starts if a uppercase special char (like german um…
f440bab 
…lauts), #351
@mjansing
Copy link
Contributor

Should be fixed with f440bab. Feel free to reopen if there are any issues.

@rbvictor rbvictor mentioned this issue Jun 22, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjansing mjansing

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fabianzwodrei @mjansing