Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update fast-glob to 3.2.8 #45

Merged
merged 2 commits into from
Jan 7, 2022
Merged

Conversation

Trott
Copy link
Collaborator

@Trott Trott commented Dec 11, 2021

No description provided.

@Trott
Copy link
Collaborator Author

Trott commented Dec 11, 2021

fast-glob@3 is not matching directories with a trailing slash in the glob. In other words, */fixtures finds test/fixtures but */fixtures/ does not in fast-glob@3, but it does find it in fast-glob@2.

Not sure if that's a bug in fast-glob or a behavior change.

With fast-glob@2:

 glob('*/fixtures/', { onlyFiles: false}).then(console.log, console.log)

...finds test/fixtures, but with fast-glob@3, it does not.

@Trott
Copy link
Collaborator Author

Trott commented Dec 11, 2021

Known bug in fast-glob@3. mrmlnc/fast-glob#290

@Trott
Copy link
Collaborator Author

Trott commented Dec 12, 2021

Fix in mrmlnc/fast-glob#335.

@Trott
Copy link
Collaborator Author

Trott commented Jan 1, 2022

When fast-glob 3.2.8 is released, we should be able to update to that.

@Trott Trott changed the title chore: update fast-glob to 3.2.7 chore: update fast-glob to 3.2.8 Jan 7, 2022
@Trott Trott merged commit a33052a into inikulin:master Jan 7, 2022
@Trott Trott deleted the fast-glob-327 branch January 7, 2022 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant