-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Threw an error on ingestion #21
Comments
hey thanks for the report! looks like neither readability nor slurp were able to find a title for this page. i'll probably have to submit a patch upstream of slurp for this one. can you share the URL? i'm not seeing it in the logs |
These were from www.fastcompany.com |
The logs were quoting a product page. I looked it up and found this: https://sparksoftcorp.com/dev-sec-ops-delivery The site doesn't have any I will be adding more options to the Slurp New Note dialog soon though. That will be the best place to manually give it a title to use. |
That's a red herring - the sparkssoft pages were ones I had ingested prior; yes, there wasn't much to pull, but I was most concerned with the text and didn't care about the metadata. It's the links from the fast company site which is what throws the error. The log output in settings didn't give me a good way to reliably tell what was needed for just the error message, so you got both of the ingestions. Literally any link from Fastcompany.com throws an error. Here's a clean example from https://www.fastcompany.com/91122708/heres-how-california-state-agencies-plan-use-generative-ai 1715349697499 | DEBUG | onValidate called
|
ah ok, yeah the error message slurp displays says that it got a 403 back from fast company, so I'm guessing that they block non-browsers from accessing their pages. I'll have a look but there's likely not much we can do about that |
fast company does seem to block application access entirely, so i've added a validation step to new note creation which will complain if a fast company link is used. did the same for that product site too. let me know if you find any other sites which just refuse to be slurped! |
<Edited to focus on the relevant error, rather than the entire log contents which had slurps that were fine even if the title was missing>
1715205555277 | DEBUG | onValidate called
HTMLDivElement.<anonymous> (app://obsidian.md/app.js:1:2170951)
The text was updated successfully, but these errors were encountered: