Title Line Breaks Cause Issues in JSON File #50
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This seems related to issue #47 , but it's showing up in a different place. Here, it seems that the line breaks are not being escaped in the resulting lunr.json file for the search functionality.
Suggested resolution
As the whitespace in a title (whether intentional or not) isn't really relevant to the search functionality, simply using the same replace function in xpath as is used elsewhere in the
data-to-json.xsl
file seems a simple and consistent fix for this issue.Configuration