Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix close button placement for Bootstrap 5.3.3 #46

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Fix close button placement for Bootstrap 5.3.3 #46

merged 2 commits into from
Mar 11, 2024

Conversation

jason-fox
Copy link
Collaborator

@jason-fox jason-fox added the enhancement New feature or request label Mar 4, 2024
@lakokkonen
Copy link

@jason-fox I guess this is related to the upgrade to BS 5.3.3?

According to the docs they've dropped the even distribution of modal headers.

@jason-fox
Copy link
Collaborator Author

@lakokkonen - correct. without being float-end the Close Button ✖️ is now looks oddly placed.

@lakokkonen
Copy link

@jason-fox Would another solution be using the class justify-content-between on the modal header? That would presumably eliminate the need to use floats.

@jason-fox
Copy link
Collaborator Author

using the classjustify-content-between on the modal header

Fixed bff4eb8

@infotexture infotexture changed the title Move button Fix close button placement for Bootstrap 5.3.3 Mar 11, 2024
@infotexture infotexture merged commit ee5eafe into infotexture:develop Mar 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infotexture infotexture infotexture approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jason-fox @lakokkonen @infotexture