Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add block_search RPC endpoint #991

Merged
merged 3 commits into from
Sep 28, 2021
Merged

Add block_search RPC endpoint #991

merged 3 commits into from
Sep 28, 2021

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Sep 28, 2021 •
edited
Loading

Partially resolves #832.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

Codecov Report

Merging #991 (f55cb22) into master (979b7b5) will decrease coverage by 0.0%.
The diff coverage is 75.8%.

❗ Current head f55cb22 differs from pull request most recent head 2907678. Consider uploading reports for the commit 2907678 to get more accurate results
Impacted file tree graph

@@           Coverage Diff            @@
##           master    #991     +/-   ##
========================================
- Coverage    72.5%   72.5%   -0.1%     
========================================
  Files         203     204      +1     
  Lines       16585   16652     +67     
========================================
+ Hits        12035   12082     +47     
- Misses       4550    4570     +20
Impacted Files Coverage Δ
abci/src/application/kvstore.rs 86.2% <ø> (ø)
abci/src/lib.rs 100.0% <ø> (ø)
rpc/src/client.rs 16.9% <ø> (ø)
rpc/src/client/bin/main.rs 0.5% <0.0%> (-0.1%) ⬇️
rpc/src/client/transport/mock.rs 89.7% <ø> (ø)
rpc/src/endpoint/block_search.rs 20.0% <20.0%> (ø)
rpc/src/method.rs 30.4% <50.0%> (+0.9%) ⬆️
rpc/tests/kvstore_fixtures.rs 95.6% <100.0%> (+0.1%) ⬆️
rpc/src/endpoint/consensus_params.rs 40.0% <0.0%> (-60.0%) ⬇️
rpc/src/endpoint/validators.rs 9.0% <0.0%> (-11.0%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 979b7b5...2907678. Read the comment docs.

@thanethomson thanethomson mentioned this pull request Sep 28, 2021
Open
9 tasks
thanethomson
thanethomson approved these changes Sep 28, 2021
View reviewed changes
Copy link
Contributor

@thanethomson thanethomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 🎉

@thanethomson thanethomson merged commit 34c5d2a into master Sep 28, 2021
@thanethomson thanethomson deleted the hu55a1n1/832-block-search branch September 28, 2021 19:26
@thanethomson thanethomson mentioned this pull request Sep 29, 2021
Closed
soareschen pushed a commit that referenced this pull request Oct 6, 2021
@thanethomson @hu55a1n1 @xla
Resolve conflict in #986 (#1004)
540e37f 
* Fix `cargo test` and add check to CI (#990)

* Relocate ABCI test to fix broken doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Use tokio_test for mock client doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CI test for default features

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add `block_search` RPC endpoint (#991)

* Add block_search RPC endpoint and tests

* Add .changelog entry

* Fix comments

* tools: Fix `block_search` endpoint integration tests (#999)

Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Build and check tools (#997)

So far only the kvstore tests ran as part of the Github workfows. This
would leave opportunity for changes to introduce breakage to the builds
of the tools. In this change the same build and clippy stages are
introduced for the tools workspace that currently run for the top-level
one.

Signed-off-by: xla <self@xla.is>

* tools: Add `block_search` method to RPC probe (#1002)

* Add missing block_search endpoint
* Bump tendermint version to v0.34.13

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>
thanethomson added a commit that referenced this pull request Oct 7, 2021
@soareschen @thanethomson
@hu55a1n1 @xla
Move out tendermint::config to tendermint-config crate (#986)
1ab5e86 
* Move out tendermint::config to tendermint_config crate

* Introduce own error type in tendermint-config

* Move tendermint::net to tendermint_config::net

* Fix tendermint-rpc error

* Update Cargo.toml for tendermint-config

* Remove #![allow(dead_code)]

* Apply suggestions from code review

Co-authored-by: Thane Thomson <thane@informal.systems>

* Move tendermint_config::files::test to tendermint_config::test

* Remove config/tests/config.rs

* Minor fixes

* Resolve conflict in #986 (#1004)

* Fix `cargo test` and add check to CI (#990)

* Relocate ABCI test to fix broken doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Use tokio_test for mock client doctest

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add CI test for default features

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add `block_search` RPC endpoint (#991)

* Add block_search RPC endpoint and tests

* Add .changelog entry

* Fix comments

* tools: Fix `block_search` endpoint integration tests (#999)

Closes #998

* Bump integration test tendermint to v0.34.13
* Fix kvstore integration tests
* Bump tendermint version to v0.34.13 in CI

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* ci: Build and check tools (#997)

So far only the kvstore tests ran as part of the Github workfows. This
would leave opportunity for changes to introduce breakage to the builds
of the tools. In this change the same build and clippy stages are
introduced for the tools workspace that currently run for the top-level
one.

Signed-off-by: xla <self@xla.is>

* tools: Add `block_search` method to RPC probe (#1002)

* Add missing block_search endpoint
* Bump tendermint version to v0.34.13

Signed-off-by: Thane Thomson <connect@thanethomson.com>

Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>

* Fix abci-test

* Add changelog entry

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add more changelog entries for other breaking changes

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Add tendermint-config to release script

Signed-off-by: Thane Thomson <connect@thanethomson.com>

* Fix merge mistakes

Co-authored-by: Thane Thomson <thane@informal.systems>
Co-authored-by: Shoaib Ahmed <sufialhussaini@gmail.com>
Co-authored-by: xla <a.simmerl@gmail.com>
Co-authored-by: Thane Thomson <connect@thanethomson.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanethomson thanethomson thanethomson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for remaining Tendermint RPC endpoints
3 participants
@hu55a1n1 @codecov-commenter @thanethomson