-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prep release v0.15.0 #454
Prep release v0.15.0 #454
Conversation
|
||
anomaly = { version = "0.2.0", features = ["serializer"] } | ||
contracts = "0.4.0" | ||
crossbeam-channel = "0.4.2" | ||
derive_more = "0.99.5" | ||
futures = "0.3.4" | ||
prost-amino = "0.5.0" | ||
prost-amino = "0.6.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -1,20 +1,20 @@ | |||
[package] | |||
name = "tendermint-light-client" | |||
version = "0.14.0" | |||
version = "0.15.0" | |||
authors = ["Romain Ruetschi <romain@informal.systems>"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
$ git shortlog -n -s -- light-client
shows
22 Romain Ruetschi
6 Alexander Simmerl
4 Ismail Khoffi
1 Ethan Buchman
1 Shivani Joshi
1 yihuang
ad845de
to
036a71b
Compare
/// - If verification fails for any other reason, the | ||
/// witness is deemed faulty. | ||
/// - If verification fails because of lack of trust, we have a potential fork. | ||
/// - If verification fails for any other reason, the witness is deemed faulty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually never enforce the rules we have via CI by running fmt via nightly at least there.
See:
Lines 1 to 12 in a556d77
unstable_features = true | |
# comments | |
comment_width = 100 | |
wrap_comments = true | |
# imports | |
reorder_imports = true | |
# strings | |
format_strings = false | |
max_width = 100 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should probably change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah let's remove the nightly-only formatting directives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documenting tendermint v0.15.0 (/Users/ismail/IdeaProjects/tendermint-rs/tendermint) error: `[Error::InvalidTrustThreshold]` cannot be resolved, ignoring it. --> tendermint/src/lite/types.rs:110:38 | 110 | /// In any other case we return [`Error::InvalidTrustThreshold`]. | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ cannot be resolved, ignoring |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
How about upgrade |
It was on my radar (#452) but I didn't try it yet as there might be breaking changes in the sled API. Can try on Monday. Feel free to submit a PR that updates it independently of this one in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dope! Just a bunch of typos.
Co-authored-by: Alexander Simmerl <a.simmerl@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌋 ☀️ 📣 🔛
@@ -1,4 +1,9 @@ | |||
## Pending | |||
## [0.15.0] (2020-07-17) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should maybe update the date here. I'll merge this for now and publish the crates this afternoon.
Sorry if this PR grew too big. I can break it into smaller ones if required but I think it should be straightforward to review.
touches parts of: #388
closes #452