Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /header RPC endpoint #1101

Closed
wants to merge 11 commits into from
Closed

Add /header RPC endpoint #1101

wants to merge 11 commits into from

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Mar 7, 2022

Implements the /header RPC endpoint (#832).

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Added entry in .changelog/

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #1101 (2af6ba6) into v0.23.x (2354801) will decrease coverage by 0.0%.
The diff coverage is 13.3%.

Impacted file tree graph

@@            Coverage Diff            @@
##           v0.23.x   #1101     +/-   ##
=========================================
- Coverage     67.3%   67.3%   -0.1%     
=========================================
  Files          212     213      +1     
  Lines        20201   20217     +16     
=========================================
+ Hits         13614   13616      +2     
- Misses        6587    6601     +14     
Impacted Files Coverage Δ
light-client/src/light_client.rs 71.7% <ø> (ø)
light-client/src/peer_list.rs 88.5% <ø> (ø)
p2p/src/error.rs 0.0% <ø> (ø)
rpc/src/client.rs 5.0% <0.0%> (-0.2%) ⬇️
rpc/src/client/bin/main.rs 0.3% <0.0%> (-0.1%) ⬇️
rpc/src/endpoint/header.rs 0.0% <0.0%> (ø)
tools/rpc-probe/src/common.rs 0.0% <0.0%> (ø)
rpc/src/method.rs 24.7% <50.0%> (+0.9%) ⬆️
config/src/config.rs 55.0% <100.0%> (ø)
tendermint/src/abci/transaction.rs 54.4% <100.0%> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2354801...2af6ba6. Read the comment docs.

@hu55a1n1
Copy link
Member Author

hu55a1n1 commented Mar 8, 2022

Seems like the /header endpoint was only added to tendermint 0.35. Will it be backported to 0.34?

@romac romac changed the title Add /header RPC endpoint Add /header RPC endpoint Nov 17, 2022
@romac
Copy link
Member

romac commented Mar 6, 2023

@mzabaluev This was subsumed by #1193, right? If so, then let's close this

@mzabaluev
Copy link
Contributor

Yes, it's supplanted by #1193.

@mzabaluev mzabaluev closed this Mar 6, 2023
@romac romac deleted the hu55a1n1/832-header branch March 6, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants