Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the flexible conn id for connection messages #334

Merged
merged 13 commits into from
Oct 22, 2020
Merged

Fix the flexible conn id for connection messages #334

merged 13 commits into from
Oct 22, 2020

Commits on Oct 21, 2020

  1. Fix the flexible conn id in Try and Ack for connection

    @ancazamfir
    ancazamfir committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    3430a2c View commit details
    Browse the repository at this point in the history

  2. Avoid cloning in MsgConnectionOpenAck::counterparty_connection_id

    @romac
    romac committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    7f69db4 View commit details
    Browse the repository at this point in the history

  3. Avoid a (safe) use of unwrap

    @romac
    romac committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    d0ffbf3 View commit details
    Browse the repository at this point in the history

  4. Add check for counterparty_connection_id new field in Try handler. 

    Allow None in Counterparty structure.
    @ancazamfir
    ancazamfir committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    f1dacaa View commit details
    Browse the repository at this point in the history

  5. fix fmt

    @ancazamfir
    ancazamfir committed Oct 21, 2020
    Configuration menu
    Copy the full SHA
    5393394 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2020

  1. Make the dest conn id optional in the tx raw cli

    @ancazamfir
    ancazamfir committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    aa6b373 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into anca/flexible_id

    @ancazamfir
    ancazamfir committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    744093a View commit details
    Browse the repository at this point in the history

  3. Update changelog

    @ancazamfir
    ancazamfir committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    3ae1bd6 View commit details
    Browse the repository at this point in the history

  4. Update modules/src/ics03_connection/msgs/conn_open_try.rs 

    Co-authored-by: Romain Ruetschi <romain@informal.systems>
    @ancazamfir @romac
    ancazamfir and romac committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    b0e8608 View commit details
    Browse the repository at this point in the history

  5. Update modules/src/ics03_connection/msgs/conn_open_ack.rs 

    Co-authored-by: Romain Ruetschi <romain@informal.systems>
    @ancazamfir @romac
    ancazamfir and romac committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    38db324 View commit details
    Browse the repository at this point in the history

  6. fix conversions

    @ancazamfir
    ancazamfir committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    a61b3d3 View commit details
    Browse the repository at this point in the history

  7. simplify more

    @ancazamfir
    ancazamfir committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    96fb534 View commit details
    Browse the repository at this point in the history

  8. review comments

    @ancazamfir
    ancazamfir committed Oct 22, 2020
    Configuration menu
    Copy the full SHA
    10e75d5 View commit details
    Browse the repository at this point in the history