Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Relayer ADR and diagrams #28

Merged
merged 9 commits into from
May 19, 2020
Merged

[WIP] Relayer ADR and diagrams #28

merged 9 commits into from
May 19, 2020

Conversation

ancazamfir
Copy link
Collaborator

Closes: #2
not yet really :)

Description

Still work in progress but would like to move to Rust implementation for what it's there so far. And a preliminary review would be really appreciated.
At this point it includes:

  • high lever overview
  • assumptions, dependencies and requirements
  • relayer configuration file
  • client operations
  • connection relay

For contributor use:

  • Wrote tests
  • Updated CHANGELOG_PENDING.md
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments
  • Re-reviewed Files changed in the Github PR explorer

@codecov-io
Copy link

codecov-io commented Mar 11, 2020 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@c67f1fc). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master     #28   +/-   ##
========================================
  Coverage          ?   17.7%           
========================================
  Files             ?      26           
  Lines             ?     428           
  Branches          ?      36           
========================================
  Hits              ?      76           
  Misses            ?     325           
  Partials          ?      27

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c67f1fc...e096cac. Read the comment docs.

@ancazamfir ancazamfir changed the title relayer ADR and diagrams [WIP]relayer ADR and diagrams Mar 11, 2020
@ancazamfir ancazamfir added I: spec Internal: related to IBC specifications work in progress I: logic Internal: related to the relaying logic labels Mar 11, 2020
adizere
adizere reviewed Mar 11, 2020
View reviewed changes
Copy link
Member

@adizere adizere left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This ADR 2 clarified quite a bit of my questions regarding the interactions in the Relayer. Left some minor comments (clarifications, suggestions).

docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
adizere
adizere reviewed Mar 12, 2020
View reviewed changes
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
docs/architecture/adr-002-ibc-relayer.md Outdated Show resolved Hide resolved
@romac romac changed the title [WIP]relayer ADR and diagrams [WIP] Relayer ADR and diagrams Mar 12, 2020
@ancazamfir ancazamfir merged commit 8e73a85 into master May 19, 2020
@ancazamfir ancazamfir deleted the anca/adr_ibc_relayer branch May 21, 2020 10:11
@ancazamfir ancazamfir mentioned this pull request May 22, 2020
Closed
4 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@ancazamfir
[WIP] Relayer ADR and diagrams (informalsystems#28)
63e8eb9 
* relayer ADR and diagrams

* some review comments

* Relayer ADR updates, move to Rust structs, small config changes

* cargo fmt

* clean figure

* add client heights diagram and explanation, some doc corrections

* corrections on event handling diagram, added also consensus state events

* small fixes before merge
ljoss17 pushed a commit that referenced this pull request Apr 22, 2024
@yito88
Support shielding transfers (#28)
31e4612 
* gen-ibc-shielded

* MsgTimeout and MsgAcknowledgement

* add refund flag

* add shielded_sync

* scripts for IBC rate limit

* not to use memo for shielded transfers

* add namada-stargaze-transfer test script

* remove duplicated masp tx

* for Namada query change

* update Namada rev

* Namada 0.33.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adizere adizere adizere left review comments

@liamsi liamsi liamsi left review comments

@milosevic milosevic milosevic approved these changes

@romac romac Awaiting requested review from romac

@ebuchman ebuchman Awaiting requested review from ebuchman

@istoilkovska istoilkovska Awaiting requested review from istoilkovska

Assignees
No one assigned
Labels
I: logic Internal: related to the relaying logic I: spec Internal: related to IBC specifications
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

IBC Relayer ADR
5 participants
@ancazamfir @codecov-io @milosevic @adizere @liamsi