Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase default for max_gas pre defined #1636

Merged
merged 3 commits into from
Dec 7, 2021
Merged

Increase default for max_gas pre defined #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
61891a2
Increase default for max_gas contains
Dec 2, 2021
93eb9c8
Merge branch 'master' into patch-1
adizere Dec 7, 2021
e30682a
changelog, consistent defaults for max_gas
adizere Dec 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .changelog/unreleased/improvements/ibc-relayer-cli/1636.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- Increase the default for `max_gas` from `300_000` to `400_000` ([#1636](https://github.com/informalsystems/ibc-rs/pull/1636))

6 changes: 3 additions & 3 deletions config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,8 +155,8 @@ store_prefix = 'ibc'
default_gas = 100000

# Specify the maximum amount of gas to be used as the gas limit for a transaction.
# Default: 300 000
max_gas = 300000
# Default: 400 000
max_gas = 400000

# Specify the price per gas used of the fee to submit a transaction and
# the denomination of the fee. Required
Expand Down Expand Up @@ -239,7 +239,7 @@ account_prefix = 'cosmos'
key_name = 'testkey'
store_prefix = 'ibc'
default_gas = 100000
max_gas = 3000000
max_gas = 400000
gas_price = { price = 0.001, denom = 'stake' }
gas_adjustment = 0.1
max_msg_num = 30
Expand Down
2 changes: 1 addition & 1 deletion relayer/src/chain/cosmos.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ mod compatibility;
pub mod version;

/// Default gas limit when submitting a transaction.
const DEFAULT_MAX_GAS: u64 = 300_000;
const DEFAULT_MAX_GAS: u64 = 400_000;
adizere marked this conversation as resolved.
Show resolved Hide resolved

/// Fraction of the estimated gas to add to the estimated gas amount when submitting a transaction.
const DEFAULT_GAS_PRICE_ADJUSTMENT: f64 = 0.1;
Expand Down