Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add keys delete command #1174

Merged
merged 16 commits into from
Aug 4, 2021
Merged

Add keys delete command #1174

merged 16 commits into from
Aug 4, 2021

Conversation

hu55a1n1
Copy link
Member

@hu55a1n1 hu55a1n1 commented Jul 12, 2021 •
edited by romac
Loading

Closes: #1065

Description

Adds the keys delete command to the Hermes CLI:

hermes keys delete <chain-id> [-n|--name <keyname>]

Usage

USAGE:
    hermes keys delete <OPTIONS>

DESCRIPTION:
    Delete key(s) from a configured chain

POSITIONAL ARGUMENTS:
    chain_id                  identifier of the chain

FLAGS:
    -n, --name NAME           name of the key
    -a, --all                 delete all keys

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@romac romac changed the title Add keys clean command Add keys clean command Jul 16, 2021
@romac romac changed the title Add keys clean command Add keys delete command Jul 16, 2021
adizere
adizere approved these changes Aug 3, 2021
View reviewed changes
Copy link
Member

@adizere adizere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@adizere
Copy link
Member

adizere commented Aug 3, 2021

This is ready for review @andynog and @greg-szabo.

romac
romac reviewed Aug 3, 2021
View reviewed changes
relayer/src/keyring.rs Outdated Show resolved Hide resolved
adizere
adizere reviewed Aug 4, 2021
View reviewed changes
relayer/src/keyring.rs Outdated Show resolved Hide resolved
@adizere adizere self-assigned this Aug 4, 2021
@adizere adizere merged commit 142c7dc into master Aug 4, 2021
@adizere adizere deleted the hu55a1n1/cli-keys-clean branch August 4, 2021 13:21
hu55a1n1 added a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@hu55a1n1 @romac @adizere
Add keys delete command (informalsystems#1174)
0d89cf8 
* Add keys clean command

* Fix comment

* Rename clean -> delete

* Add delete all option

* Update CHANGELOG.md

* Update docs

* Reverted changelog modifications

* Changelog with unclog

* Adapted errors to flex

* FMT

* Fix error type

* Fix clippy warning

* Properly fix Clippy warning

Co-authored-by: Romain Ruetschi <romain@informal.systems>
Co-authored-by: Adi Seredinschi <adi@informal.systems>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romac romac romac left review comments

@adizere adizere adizere approved these changes

@ancazamfir ancazamfir Awaiting requested review from ancazamfir

Assignees

@adizere adizere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a keys delete command to remove keys from Hermes configuration
3 participants
@hu55a1n1 @adizere @romac