Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Hermes log messages #1138

Merged
merged 1 commit into from
Jul 5, 2021
Merged

Adjust Hermes log messages #1138

merged 1 commit into from
Jul 5, 2021

Conversation

adizere
Copy link
Member

@adizere adizere commented Jun 30, 2021

Closes: #XXX

Description

For contributor use:

  • Updated the Unreleased section of CHANGELOG.md with the issue.
  • If applicable: Unit tests written, added test to CI.
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Updated relevant documentation (docs/) and code comments.
  • Re-reviewed Files changed in the Github PR explorer.

@adizere adizere changed the title Adjust logs to avoid misleading error messages Adjust Hermes log messages Jul 3, 2021
@adizere adizere added the E: gravity External: related to Gravity DEX label Jul 5, 2021
@ancazamfir ancazamfir marked this pull request as ready for review July 5, 2021 20:11
@ancazamfir ancazamfir requested a review from romac as a code owner July 5, 2021 20:11
@ancazamfir ancazamfir merged commit 8b61653 into master Jul 5, 2021
@ancazamfir ancazamfir deleted the adi/ux_logs branch July 5, 2021 20:11
@adizere adizere mentioned this pull request Aug 3, 2021
Closed
13 tasks
hu55a1n1 pushed a commit to hu55a1n1/hermes that referenced this pull request Sep 13, 2022
@adizere
Lowered error log lvl to warn, re: misbehavior missing headers (infor…
4975785 
…malsystems#1138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ancazamfir ancazamfir ancazamfir approved these changes

@romac romac Awaiting requested review from romac

Assignees
No one assigned
Labels
E: gravity External: related to Gravity DEX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adizere @ancazamfir