Restart the event monitor event loop to reinitialize the subscriptions Stream after a restart
#1027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romac
force-pushed
the
romac/fix-monitor-restart
branch
from
509124e
to
64e2a72
Compare
adizere
approved these changes
Jun 2, 2021
|
Should we update the changelog also? |
ancazamfir
approved these changes
Jun 2, 2021
There was a problem hiding this comment.
Looks good! There is more work to do to properly handle disconnect/ reconnect, see #1026 (comment). But definitely in separate issues and PRs. Thanks Romain!
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this pull request
Sep 13, 2022
…s `Stream` after a restart (informalsystems#1027) * Add chain id to tracing messages in event monitor * Restart the event loop after restarting the WebSocket client * Restart the event loop in a stack-safe fashion * Remove trampoline, and just use `return` instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1026
Description
Restart the event monitor event loop to reinitialize the subscriptions
Streamafter a restart.For contributor use:
docs/) and code comments.Files changedin the Github PR explorer.