Make proposal deposit denomination configurable #1662
Assignees
Labels
A: good-first-issue
Admin: good for newcomers
A: low-priority
Admin: low priority / non urgent issue, expect longer wait time for PR reviews
I: CLI
Internal: related to the relayer's CLI
O: usability
Objective: cause to improve the user experience (UX) and ease using the product
Milestone
Comments
V-Staykov
changed the title
adizere
added
I: CLI
|
Good suggestion, thanks for flagging this! We're on it. Note that we're slowing down development and the whole team will go on holidays soon, so we'll ship this in the next release (~January). Hope this timeline works, though we can try to move faster if this is a blocker or a major issue. Let me know if so! |
12 tasks
adizere
added
the
A: low-priority
6 tasks
mzabaluev
added a commit
that referenced
this issue
Jan 19, 2022
Co-authored-by: Romain Ruetschi <romain@informal.systems>
romac
added a commit
that referenced
this issue
Jan 19, 2022
…the deposit denomination configurable (#1790) * Normalize Cargo.lock Apply changes automatically made by cargo 1.58.0. * --denom option for hermes tx raw upgrade-chain Make the denomination string configurable in the chain upgrade proposal issued by the `tx raw upgrade-chain` command. * Changelog entries for #1790 * Improve the changelog entry for #1662 (the relayer-cli part) Co-authored-by: Romain Ruetschi <romain@informal.systems> * Fix typo in the doc for --denom option Co-authored-by: Romain Ruetschi <romain@informal.systems> * Use Option::as_deref Co-authored-by: Romain Ruetschi <romain@informal.systems>
hu55a1n1
pushed a commit
to hu55a1n1/hermes
that referenced
this issue
Sep 13, 2022
…the deposit denomination configurable (informalsystems#1790) * Normalize Cargo.lock Apply changes automatically made by cargo 1.58.0. * --denom option for hermes tx raw upgrade-chain Make the denomination string configurable in the chain upgrade proposal issued by the `tx raw upgrade-chain` command. * Changelog entries for informalsystems#1790 * Improve the changelog entry for informalsystems#1662 (the relayer-cli part) Co-authored-by: Romain Ruetschi <romain@informal.systems> * Fix typo in the doc for --denom option Co-authored-by: Romain Ruetschi <romain@informal.systems> * Use Option::as_deref Co-authored-by: Romain Ruetschi <romain@informal.systems>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Crate
ibc-relayer-cli
Summary
Currently, when trying to make an ibc-upgrade proposal from Hermes, the deposit denomination is hard coded to stake. Would be good for it to be configurable.
Problem Definition
The feature to make proposals through Hermes is unusable on chains with different deposit denom.
Proposal
Either the CLI to accept amount and denom i.e.
1000denom, or the denom to be configurable in the config.tomlAcceptance Criteria
hermes tx raw upgrade-chain ibc-0 ibc-1 07-tendermint-0 10000000 300should have another option--denomthat can be a String (or a domain type wrapping over String).stake, cf: https://github.com/informalsystems/ibc-rs/blob/37d54d4d851d3d7af394845e05b17b4d0e66afd7/relayer/src/upgrade_chain.rs#L117For Admin Use
The text was updated successfully, but these errors were encountered: