Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7228 - Fix npm commands #7229

Merged
merged 6 commits into from
Feb 17, 2023
Merged

7228 - Fix npm commands #7229

merged 6 commits into from
Feb 17, 2023

Conversation

tmcconechy
Copy link
Member

Explain the details for making this change. What existing problem does the pull request solve?

The clean commands did not work due to isaacs/rimraf#249

Related github/jira issue (required):
Fixes #7228

Steps necessary to review your pull request (required):

  • pull this on a windows machine
  • make sure you npm i from before
  • test commands:
npm run clean:docs
npm run clean
npm run start

Included in this Pull Request:

  • A note to the change log.

@tmcconechy tmcconechy requested a review from a team as a code owner February 16, 2023 16:26
Copy link
Contributor

@danielortiz1982 danielortiz1982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on a HP running Windows 10 all good.

@tmcconechy
Copy link
Member Author

@awbuboltz your right the ids-website should be cleared. I made an update. But i think this command is almost not really needed but just in case.

@awbuboltz
Copy link
Contributor

Changes make sense to me and it now works on Windows.

@tmcconechy
Copy link
Member Author

cool - considering this approved but a wierd thing with the tests happened. Cant be related so retrying

@tmcconechy tmcconechy merged commit d6c2c0f into main Feb 17, 2023
@tmcconechy tmcconechy deleted the 7228-fix-windows branch February 17, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build: Cannot Run the Build on Windows
3 participants