-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Safari support #64
Comments
I welcome PRs that add support to Safari. It shouldn't be hard, but it should be implemented and maintained by someone who is regularly using Safari. |
Tried converting current release of this extension with Safari Web Extension Converter (Xcode 12.5.1) using:
..but I encounter an error:
Any hints? |
@srikat any way you can distribute your Safari port? |
Yeah, @srikat, would love to try your port! |
have you found any solution about that? |
Sadlo, no :/ switched to chrome cause I really missed this feature.
…On Wed, 6 Apr 2022 at 08:49, Ceren ***@***.***> wrote:
Tried converting current release of this extension with Safari Web
Extension Converter (Xcode 12.5.1) using:
xcrun safari-web-extension-converter <folder>
..but I encounter an error:
Unable to parse manifest.json at …
Any hints?
have you found any solution about that?
—
Reply to this email directly, view it on GitHub
<#64 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHX3W5E4XDARYCKKHZCZM33VDUXZFANCNFSM4FHII3AQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
I have figured out how to get the converter to work but the extension is not working as expected on Safari. I see the blue arrow but when I press
I'm a bit stuck, not sure what to try next. Any tips @srikat? I'm not very familiar with debugging Safari extensions. Any resources or advice? P.s. I also followed the instructions for signing the target but still same thing. |
I did a bit of debugging and it looks like the program is hanging the first time I modified this part of the code with the log statement: // main.js
...
WebSearchNavigator {
...
bindKeys() {
...
if (global) {
...
} else {
console.log("We are about to bind shortcut \"" + shortcut + "\" with Mousetrap")
Mousetrap(element).bind(shortcut, wrappedCallback);
console.log("We have finished binding shortcut \"" + shortcut + "\" with Mousetrap")
}
...
console.log("Ending the bindKeys call")
}
...
}
... And my console output is only this:
So it looks like |
One more update: I have a new error message in my console. Not sure why it was not coming up before but now I'm seeing this:
I think I have not installed the dependencies correctly before converting this to a Safari extension. |
@jackhodkinson just a guess, but did you run |
Thank you @infokiller that worked! 🎉 Steps to make this work:
To avoid having to re-enable unsigned extensions every time you open Safari follow these instructions to sign the extension and rebuild it. So I have got this working for me but not sure how I can help distribute this to help others. Should I make a PR in |
Thanks @jackhodkinson for making it work and documenting the process! |
This helps me to sign the extension so I can use it without allowing unsigned extensions. |
@infokiller Is there still any plan to package this as an App Store application? Just found out about this extension, and it's exactly what I needed. But the steps above somehow does not work for me. (failed in step 3) |
@NikoKS I'm not aware of any plan, I don't use Safari at all so someone will need to volunteer |
I also encountered troubles in the step 3, and ended up knowing that "safari-web-extension-converter" should be called in a full name. But I don't have a development account, so the extension would be hidden for every time opening Safari. Still need someone has an account to publish. |
This extension is available for Chrome, Firefox, and Edge. Excellent, but what about Safari? ;)
The text was updated successfully, but these errors were encountered: