Release 5.0.0 #434
Merged
Release 5.0.0 #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # composer.json # composer.lock
* adding new conditional options for output item
# Conflicts: # composer.json # composer.lock # src/Blocks/components/form/form.php # src/Blocks/components/form/manifest.json # src/Form/Form.php # src/General/SettingsGeneral.php
iruzevic
changed the title
piqusy
requested changes
Jul 20, 2024
|
Nice work 👏🏼 Left a few suggestions |
goranalkovic-infinum
requested changes
Jul 22, 2024
| @@ -1,3 +1,5 @@ | |||
| // stylelint-disable scss/load-partial-extension | |||
There was a problem hiding this comment.
This looks like it's fixed on lines 17 and 18, does it still need to be here?
There was a problem hiding this comment.
when I remove this glob loader is not working so this needs to stay :(
src/Blocks/custom/result-output-item/components/result-output-item-editor.js
Outdated
Show resolved
Hide resolved
dingo-d
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Other than the comments by @goranalkovic-infinum and @piqusy looks ok to me 👍🏼
src/Blocks/custom/result-output-item/components/result-output-item-editor.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com> Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com>
Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com>
Co-authored-by: Goran Alković <77000136+goranalkovic-infinum@users.noreply.github.com> Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
…result-output # Conflicts: # src/Integrations/AbstractSettingsIntegrations.php
Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
dingo-d
previously approved these changes
Jul 22, 2024
piqusy
previously approved these changes
Jul 22, 2024
Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
Co-authored-by: Ivan Ramljak <22823970+piqusy@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
beforeSuccessResponsefor the forms.mailerSuccessRedirectUrl,mailerEntryId,mailerEntryUrlthat can be used in any email.esFormsROISFshortcode that can be used inside the result output item to show the form again.Removed
successRedirectVariation,successRedirectVariationOptions,preResponseAddonData,preResponseSuccessRedirectData,resultOutputItems,resultOutputParts.Changed
esFormsROIPshortcode now supports variation data submission.Fixed
Screenshots / Videos
Linked documentation PR