NeighborListCache: don't build neighbor list during initialization #983
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given n radios, neighbor list construction has O(n^2) complexity. If, during initialization, when each radio is added, the neighbor list is reconstructed, we end up having a simulation initialization with O(n^3) complexity. Sidenote: In one of our tests, without this patch, when running a WiFi simulation of 5000 nodes, it took ~40 minutes to just initialize the simulation.
|
Thanks for submitting this PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given n radios, neighbor list construction has O(n^2) complexity. If, during initialization, when each radio is added, the neighbor list is reconstructed, we end up having a simulation initialization with O(n^3) complexity.
Sidenote: In one of our tests, without this patch, when running a WiFi simulation of 5000 nodes, it took ~40 minutes to just initialize the simulation.