Skip to content

Commit

Permalink
buffer: improve Buffer constructor
Browse files Browse the repository at this point in the history
Increase the performance of new Buffer construction by initializing all
properties before SetIndexedPropertiesToExternalArrayData call.

Reviewed-by: Trevor Norris <trev.norris@gmail.com>
  • Loading branch information
kennyluck authored and trevnorris committed Sep 20, 2014
1 parent d66adf0 commit 4c9b30d
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions lib/buffer.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ function Buffer(subject, encoding) {
'size: 0x' + kMaxLength.toString(16) + ' bytes');
}

this.parent = null;
if (this.length <= (Buffer.poolSize >>> 1) && this.length > 0) {
if (this.length > poolSize - poolOffset)
createPool();
Expand Down Expand Up @@ -217,11 +218,6 @@ Buffer.byteLength = function(str, enc) {
};


// pre-set for values that may exist in the future
Buffer.prototype.length = undefined;
Buffer.prototype.parent = undefined;


// toString(encoding, start=0, end=buffer.length)
Buffer.prototype.toString = function(encoding, start, end) {
var loweredCase = false;
Expand Down

0 comments on commit 4c9b30d

Please sign in to comment.