Fix _InameDuplicator.within #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
kaushikcfd
commented
Jul 29, 2024
kaushikcfd
commented
- Changed to update the inames of the instructions that do not access an inames, yet, are nested within the iname to be duplicated.
- Closes Bug in lp.duplicate_inames #859
|
Thanks! Could you look at the test failures? They seem related. |
kaushikcfd
force-pushed
the
fix-gh-859
branch
2 times, most recently
from
4bb98c5
to
58a2072
Compare
Seemed to be a bug in kernel.creation. Looks like we were calling duplicate_inames without adding the relevant inames within the insns. Also, TIL about the "dup=i" syntax in make_kernel. :) |
inducer
reviewed
Jul 29, 2024
* Changed to update the inames of the instructions that do not access an inames, yet, are nested within the iname to be duplicated.
|
Thx! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.