Zoom Rooms Plugin #173
Draft
Zoom Rooms Plugin #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pferreir
force-pushed
the
zoom-rooms
branch
5 times, most recently
from
06bce5b
to
4bfafe1
Compare
ThiefMaster
force-pushed
the
zoom-rooms
branch
from
4bfafe1
to
3489324
Compare
- Use hatchling - Fix distribution name (`indico-plugin-...`)
ThiefMaster
force-pushed
the
zoom-rooms
branch
from
3489324
to
427d8d7
Compare
ThiefMaster
reviewed
Aug 16, 2024
| '<span class="', | ||
| states[newState].icon, | ||
| '"><strong style="margin-left: 0.4em;">{0}</strong></span>'.format(name), | ||
| `<i class="icon ${states[newState].icon}"></i> ${name}` | ||
| ].join(''); |
There was a problem hiding this comment.
that array join isn't needed anymore now that it's just one string
| sa.CheckConstraint('action = 2 OR extra_args IS NULL', name=op.f('ck_queue_move_has_extra_args')), | ||
| sa.CheckConstraint('action = 2 OR extra_args IS NULL', name=op.f('ck_queue_other_actions_have_no_extra_args')), | ||
| sa.CheckConstraint('action = 3 OR entry_data IS NOT NULL', name=op.f('ck_queue_other_actions_have_args')), | ||
| sa.PrimaryKeyConstraint('id', name=op.f('pk_queue')), |
There was a problem hiding this comment.
primary_key=True on the column
| sa.Column('entry_data', postgresql.JSONB(none_as_null=True, astext_type=sa.Text()), nullable=True), | ||
| sa.Column('extra_args', postgresql.JSONB(none_as_null=True, astext_type=sa.Text()), nullable=True), | ||
| sa.CheckConstraint( | ||
| 'action != 3 OR (entry_data IS NULL AND extra_args IS NULL)', name=op.f('ck_queue_delete_has_no_args') |
There was a problem hiding this comment.
Suggested change
| 'action != 3 OR (entry_data IS NULL AND extra_args IS NULL)', name=op.f('ck_queue_delete_has_no_args') | |
| 'action != 3 OR (entry_data IS NULL AND extra_args IS NULL)', name='delete_has_no_args') |
likewise for the others (the naming convention generates the rest)
|
|
||
| def __repr__(self): | ||
| action = ZoomRoomsAction(self.action).name | ||
| return f'<ZoomRoomsQueueEntry({self.id}, {self.entry_id}, {action})>' |
There was a problem hiding this comment.
there's a nice format_repr util for that
Comment on lines
+60
to
+63
| zr_id = get_zoom_room_id(link_obj.room) | ||
|
|
||
| # do not bother doing anything if the room is not ZR-enabled | ||
| if zr_id: |
There was a problem hiding this comment.
Suggested change
| zr_id = get_zoom_room_id(link_obj.room) | |
| # do not bother doing anything if the room is not ZR-enabled | |
| if zr_id: | |
| # do not bother doing anything if the room is not ZR-enabled | |
| if zr_id := get_zoom_room_id(link_obj.room): |
|
|
||
| configurable = True | ||
| settings_form = PluginSettingsForm | ||
| friendly_name = 'Zoom Rooms' |
There was a problem hiding this comment.
Not needed, the first docstring line is the default for this
Suggested change
| friendly_name = 'Zoom Rooms' |
Comment on lines
+27
to
+35
| if ( | ||
| room | ||
| and (attributes := room.attributes) | ||
| and ( | ||
| user_id_attr := attributes.filter(RoomAttribute.name == 'zoom-rooms-calendar-id') | ||
| .join(RoomAttribute) | ||
| .first() | ||
| ) | ||
| ): |
There was a problem hiding this comment.
really? :D
(not a fan of running queries inside an if unless they all fit in a single line)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third instalment of indico/indico#6475. See also indico/indico-plugins#236
Changes:
TODO:
https://link/to/docswith the true URL, once there is one. Or even better, add a plugin setting to set the URL.