Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CERNAccess: Integrate with accompanying persons field #113

Merged
merged 30 commits into from
Nov 10, 2023
Merged

CERNAccess: Integrate with accompanying persons field #113

merged 30 commits into from
Nov 10, 2023

Conversation

duartegalvao
Copy link
Member

@duartegalvao duartegalvao commented May 19, 2022 •
edited
Loading

This PR adds integration between the CERN Access plugin and the accompanying persons field, by adding the option to include accompanying persons in the access request.

Progress:

  • Add plugin setting for including accompanying persons
  • Request information from accompanying persons in regform
  • Request information from accompanying persons in AccessIdentityDataForm
  • Obtain accompanying person's UUIDs from temporary ID
  • Disallow changing information after access request has been sent
  • Generate badges for accompanying persons
  • Write unit tests

@duartegalvao duartegalvao force-pushed the accompanying-persons branch 5 times, most recently from c73f31b to f775f64 Compare May 23, 2022 08:23
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 2 times, most recently from 0af96a5 to 185f1f9 Compare May 30, 2022 16:14
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 3 times, most recently from a962a4c to 446dc3e Compare June 23, 2022 09:02
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 5 times, most recently from 1482390 to 8adc1f8 Compare July 7, 2022 10:30
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 2 times, most recently from 08e43a3 to a701ca1 Compare July 12, 2022 09:43
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 3 times, most recently from a54fa9d to ad09e4e Compare July 18, 2022 15:29
@duartegalvao duartegalvao mentioned this pull request Aug 4, 2022
Merged
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 2 times, most recently from dc69030 to add7115 Compare July 7, 2023 09:05
@duartegalvao duartegalvao force-pushed the accompanying-persons branch 2 times, most recently from 0dc8bf9 to 8b2b6af Compare August 23, 2023 08:57
ThiefMaster
ThiefMaster reviewed Nov 9, 2023
View reviewed changes
cern_access/indico_cern_access/client/index.js Outdated Show resolved Hide resolved
cern_access/indico_cern_access/util.py Outdated Show resolved Hide resolved
cern_access/tests/operations_test.py Outdated Show resolved Hide resolved
cern_access/tests/util_test.py Outdated Show resolved Hide resolved
@ThiefMaster ThiefMaster merged commit c775515 into indico:master Nov 10, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThiefMaster ThiefMaster ThiefMaster left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@duartegalvao @ThiefMaster @tomasr8