-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make view of FormController available in *RenderViewEvents #1054
base: master
Are you sure you want to change the base?
Conversation
The update of VariablesViewHelper.php solves issue #1061 |
Hi Harald Thanks for your pull request and your efforts. Since the method signature of the event is public api, I cannot add it this way. These changes are breaking. The next breaking changes will be with the TYPO3 v13 compatible version. If you can make it non-braking, I will have another look. Non-breaking means:
Marcus |
Hi Marcus Yes you are right. In general it would be breaking if some third party would make an instance of these events. But it doesn't hurt. I'll make this non-breaking. Harald |
$this-view moved to the end of the parameters list of *RenderViewEvent(s) to make changes non-breaking.
$this-view moved to the end of the parameters list of *RenderViewEvent(s) to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
I've used those changes to fix error with f:cObject in plugin's thx.body and it worked. |
That's fine. For the problem with f:cObject this change would have been enough: All other changes are new features |
nullable view in getter and setter
nullable view in getter and setter
nullable view in getter and setter
@haraldwitt, thanks for your patch! Working just fine ;-) |
This resolves issue:
#1053