Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make view of FormController available in *RenderViewEvents #1054

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

haraldwitt
Copy link

This resolves issue:
#1053

@haraldwitt
Copy link
Author

The update of VariablesViewHelper.php solves issue #1061

@mschwemer
Copy link
Collaborator

Hi Harald

Thanks for your pull request and your efforts.

Since the method signature of the event is public api, I cannot add it this way. These changes are breaking. The next breaking changes will be with the TYPO3 v13 compatible version.

If you can make it non-braking, I will have another look.

Non-breaking means:

  • move the new argument to the end of the method signature
  • make the argument optional

Marcus

@haraldwitt
Copy link
Author

haraldwitt commented Jul 15, 2024

Hi Marcus

Yes you are right. In general it would be breaking if some third party would make an instance of these events.
But I'ts the sense of the events to avoid exactly this. The third party should always use EventListeners and the getters and setters of the event.

But it doesn't hurt. I'll make this non-breaking.

Harald

$this-view moved to the end of the parameters list of *RenderViewEvent(s) to make changes non-breaking.
$this-view moved to the end of the parameters list of *RenderViewEvent(s) to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
$this-view moved to the end of the parameters list of contructor of *RenderViewEvent(s) and add a default value to make changes non-breaking.
@rupasix
Copy link

rupasix commented Jul 17, 2024

I've used those changes to fix error with f:cObject in plugin's thx.body and it worked.

@haraldwitt
Copy link
Author

haraldwitt commented Jul 17, 2024

That's fine. For the problem with f:cObject this change would have been enough:
c826abd

All other changes are new features

@kitzberger
Copy link
Contributor

@haraldwitt, thanks for your patch! Working just fine ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants