Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External messaging #377

Merged
merged 6 commits into from
Sep 17, 2024
Merged

External messaging #377

merged 6 commits into from
Sep 17, 2024

Conversation

kairoaraujo
Copy link
Collaborator

@kairoaraujo kairoaraujo commented Sep 13, 2024

What this PR does / why we need it

This PR adds a Publisher feature to the Archivista to support external messaging and integrations.

It supports multiple publishers at the same time.

In this PR also is added the following:

  • DAPR Publisher using HTTP requests
  • RSTUF integration adding attestations/policies to the TUF metadata

There are two TODOs that I'm my opinion, can be added as follow-up improvements

  • Use goroutines for publishing, which will speed up when users enable more than one publisher (ie. DAPR+RSTUF)
  • Manage the RSTUF task in the background to reprocess and handle errors.

Acceptance Criteria Met

  • Docs changes if needed
  • Testing changes if needed
  • All workflow checks passing (automatically enforced)
  • All review conversations resolved (automatically enforced)
  • DCO Sign-off

Special notes for your reviewer:

jkjell and others added 4 commits September 13, 2024 14:45
…from archivista

Signed-off-by: John Kjell <john@testifysec.com>
Add a publisher store to enable Archivista to publish information using
different protocols and integrations

Signed-off-by: Kairo Araujo <kairo.araujo@testifysec.com>
this publisher allows users to publish messages (gitoid/dsse payload) to
a dapr HTTP pub/sub.

Signed-off-by: Kairo Araujo <kairo.araujo@testifysec.com>
this publisher allows users to integrate Archivista with Repository
Service for TUF, in order to secure the Archivista repository using TUF
metadata signatures.

Signed-off-by: Kairo Araujo <kairo.araujo@testifysec.com>
@ChaosInTheCRD
Copy link
Collaborator

apart from the comment above, all looks good to me 😄

Signed-off-by: Kairo Araujo <kairo.araujo@testifysec.com>
@ChaosInTheCRD
Copy link
Collaborator

lgtm

@jkjell jkjell merged commit ab2a157 into main Sep 17, 2024
11 checks passed
@jkjell jkjell deleted the external-messaging branch September 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants