Add full mock installation and unit tests #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor test_intoto.py to provide a better scaffolding for tests that mock the routines triggered by `apt-get install`. And add multiple tests that mock `apt-get install` with different parameters and thus different results.
We can include coverage for __main__ because the intoto transport is tested as program (in a subprocess).
Huge parts of the in-toto transport are tested in tests_intoto.py by mocking the entire installation routines. For some special cases, especially error handling it is not feasible to test them in the course of an entire installation. Those are covered in unit tests added with this commit. This commit also adds to small fixes: - Error handling in message deserialization (log level) - Remove trailing whitespace in error message.
Add no cover pragmas to lines, where testing is not feasible and also not relevant.
Change dummy inspection /usr/bin/true to true and hope that the executing shell has it on the path, to fix travis error: In-toto verification for '[stripped]/final-product_0.0.0.0-0_all.deb' failed, reason was: [Errno 2] No such file or directory: u'/usr/bin/true' See https://github.com/in-toto/in-toto/issues/247 for discussion about dummy inspections.
This was referenced Jan 3, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #:
Mostly fixes #9
Description of the changes being introduced by the pull request:
Refactor
test_intoto.pymock installation scaffolding for easier testing of different scenarios, i.e. with passing and failing (for different reasons) in-toto verification.Add additional unit tests
test_units.pyto cover cases that are not feasible to be tested in the course of above mock installation.Please verify and check that the pull request fulfills the following
requirements: