Ignore connections that fail parsing instead of panicking on BSD

[cyqsimon]

Will fix #217.

What I'm doing not is not ideal - I think there should be some kind of warning when parsing fails, but I'm not sure what's the most appropriate way to raise this warning. But at least it's better than panicking.

MacOS & BSD users can you please test this patch? Pay particular attention to whether there are missing connections. Thanks.

Further improvements very much welcomed.

[cyqsimon]

Rebased

[sigmaSd]

I think it would be great if we have a log file where can write such warnings.

[cyqsimon]

I think it would be great if we have a log file where can write such warnings.

Sounds reasonable. I'll find some time this week to add the logging infrastructure.

[cyqsimon]

Rebased.

[cyqsimon]

Rebased.

[cyqsimon]

For the moment this is the only bit of code that logs anything. I will look to add more logging incrementally.

[sigmaSd]

The logging is currently optional , I think it should always happen

bandwhich/src/cli.rs

Line 33 in 1c996c3

pub log_to: Option<PathBuf>,

[sigmaSd]

Actually nvm I don't feel that strong about it

[cyqsimon]

I made it optional because I feel like it's only really useful as a mechanism to help us debug users' issues. Not to mention that we would have to deal with log rotation (on different platforms no less, yuck). So this is good enough for now. We can always change it in the future if necessary.