Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the loss of large, merged packets #158

Merged
merged 1 commit into from
Mar 31, 2020

Conversation

TheLostLambda
Copy link
Collaborator

A good thing I took a second look at this. Just bumping the read_buffer_size to the max allowed by the kernel solves the problem. One line in one file!

Wild how it can make so much of a difference...

Here is the current (master) bandwhich on the left, wget in the middle, and this patched version on the left: https://imgur.com/HmDyaOe

@imsnif
Copy link
Owner

imsnif commented Mar 31, 2020

Hey, that's awesome! Good job.
Maybe I misunderstand the read_buffer, but wouldn't we be missing smaller frames that come along? Or am I misunderstanding what the read_buffer means?

@TheLostLambda
Copy link
Collaborator Author

As I understand it, it's the sort of maximum size that it can read in. The default size is 4096, but during my debugging, I found that smaller ones were still let through. I think it just acts as a maximum size with the trade-off being more memory is allocated.

@imsnif
Copy link
Owner

imsnif commented Mar 31, 2020

Sounds great. Doesn't seem to be using more resources in a noticeable way for me. Let's go for it.

Thank you very much for your hard work on this! Solid job.

@imsnif imsnif merged commit 79623d3 into imsnif:master Mar 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants