feat(layout): new layout #139
Conversation
|
This layout looks great! Is there anyway to signal the user that domain names are truncated? |
I don't have a good idea how to communicate this with colors, but I definitely see your point... how about if we add square brackets? Something like |
Awesome! |
Cool - I'll add this (plus a test for it, which I now realize I forgot about) tomorrow |
|
Right - so I made the adjustments. This is ready for a review. |
|
|
||
| fn truncate_middle(row: &str, max_length: u16) -> String { | ||
| if row.len() as u16 > max_length { | ||
| let first_slice = &row[0..(max_length as usize / 2) - 2]; |
There was a problem hiding this comment.
Not very important as the inputs are literals, but we could enforce that
- max_length / 2 >= 2
- row.len() >= max_length / 2 + 2
To avoid invalid indexes
There was a problem hiding this comment.
It's a good point... I had this in mind, but couldn't think about what I'd like to happen if that's the case. Do you have any ideas?
There was a problem hiding this comment.
hah, good question. This should only happen if the max_length is so small that the [..] itself does not fit and/or the hostname is also too small. Not sure, but maybe just as many dots as it fits, or just a dash?
There was a problem hiding this comment.
IMO this can only be a programmer error, since these values are hard-coded. Maybe just an expect so at least at runtime they know what went wrong?
|
I'll merge this in a few days because I also have to record a new demo gif, and I want to try for one that shows the responsive resizing. That's apparently still a challenge these days. ;P |
This is a first draft for solving: #109
It introduces a new layout, middle truncation of long table rows that would otherwise overflow their respective columns (eg.
i.am.a.long.hostnamewould becomei am a...stname), and some better (I hope) column spacing inside the tables themselves.The code is just a draft and the tests will all fail. I'd like to hear some opinions before moving forward with this. If you are reading this and have an opinion - I would very much like to hear it!
Demo: