Fix bug that upload speed is not tabulated correctly #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangxp1998
force-pushed
the
upload_speed
branch
from
b242ee2
to
cb958cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #115
The bug is here:
bandwhich/src/os/shared.rs
Line 107 in 0edc6c2
We filtered
network_framesiterator but notnetwork_interfaces. As a result, these two vectors go out of sync. That is why sometimes the sniffer thread receive packets from inactive interfaces. Since inactive interfaces don't have IP addr, sniffer assumed that packets are all in download direction