Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: add config and action to codespell the code to avoid known typos #126

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

yarikoptic
Copy link

No description provided.

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@sravan953 sravan953 self-assigned this Aug 15, 2023
@sravan953 sravan953 added the enhancement New feature or request label Aug 15, 2023
@sravan953
Copy link
Collaborator

Thanks for this @yarikoptic ! Does codespell then submit a PR with corrections?

@yarikoptic
Copy link
Author

no -- just fails the workflow and it would be for contributor to fix locally (by running codespell or manually)

@sravan953
Copy link
Collaborator

I understand how this would work for PRs, but would it open an issue for pushes to the dev branch?

@yarikoptic
Copy link
Author

nope, it would just fail the workflow (in https://github.com/imr-framework/pypulseq/actions). But sending out PRs sounds like a cool feature to request , so I did: codespell-project/actions-codespell#68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants