Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Test] add explicit marker for trailing whitespace in cases #3045

Merged
merged 1 commit into from
Sep 2, 2024

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Sep 2, 2024

This ensures that IDEs like Webstorm won't trim trailing whitespace that is expected as part of test output

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.30%. Comparing base (038c26c) to head (8bdb32b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3045      +/-   ##
==========================================
+ Coverage   95.19%   95.30%   +0.11%     
==========================================
  Files          81       81              
  Lines        3411     3411              
  Branches     1195     1195              
==========================================
+ Hits         3247     3251       +4     
+ Misses        164      160       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! this is good test case hygiene anyways :-)

@ljharb ljharb changed the title test: add explicit marker for trailing whitespace in cases [Test] add explicit marker for trailing whitespace in cases Sep 2, 2024
@ljharb ljharb merged commit 8bdb32b into import-js:main Sep 2, 2024
309 checks passed
@G-Rath G-Rath deleted the add-whitespace-end branch September 2, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants