Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(i18n): add Persian translation and support rtl languageDirection #301

Merged
merged 6 commits into from
Feb 19, 2024

Conversation

Goudarz
Copy link
Contributor

@Goudarz Goudarz commented Feb 19, 2024

Complete Persian translation of the documentation and also adding the languageDirection method to the hugo.yaml file.

Copy link

netlify bot commented Feb 19, 2024

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit c65b290
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/65d3c7aa8658c10008202fd6
😎 Deploy Preview https://deploy-preview-301--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

layouts/_default/baseof.html Outdated Show resolved Hide resolved
exampleSite/hugo.yaml Outdated Show resolved Hide resolved
exampleSite/hugo.yaml Outdated Show resolved Hide resolved
@Goudarz Goudarz requested a review from imfing February 19, 2024 21:38
@imfing
Copy link
Owner

imfing commented Feb 19, 2024

@Goudarz awesome job on the translations! Thanks for translating all the docs.

Didn't double-check the translations, but everything looks good on this link: deploy-preview-301--hugo-hextra.netlify.app

If you spot any issues with how the theme supports right-to-left languages, please drop an issue or PR, thanks!

@imfing imfing changed the title docs(i18n): Add Persian translation docs(i18n): add Persian translation Feb 19, 2024
@imfing imfing changed the title docs(i18n): add Persian translation docs(i18n): add Persian translation and support rtl languageDirection Feb 19, 2024
@imfing imfing merged commit 9995617 into imfing:main Feb 19, 2024
4 checks passed
@Goudarz Goudarz deleted the i18n-add-persian-translation branch February 19, 2024 21:44
@dogweather
Copy link
Contributor

dogweather commented Apr 2, 2024

@Goudarz What do you think about this issue: do codeblocks on Persian sites have the same issue as Hebrew? #347

I'm considering submitting a PR that hard codes dir="ltr" like I do there.

Is there ever a reason for codeblocks not to be ltr?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants