Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing translation in blog list #142

Merged
merged 3 commits into from
Oct 16, 2023

Conversation

iju707
Copy link
Contributor

@iju707 iju707 commented Oct 13, 2023

In blog list page,
"Read More →" is not a variable that can be translated.

@netlify
Copy link

netlify bot commented Oct 13, 2023

Deploy Preview for hugo-hextra ready!

Name Link
🔨 Latest commit f8b7632
🔍 Latest deploy log https://app.netlify.com/sites/hugo-hextra/deploys/652d2c7502cd7c000894468e
😎 Deploy Preview https://deploy-preview-142--hugo-hextra.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@iju707
Copy link
Contributor Author

iju707 commented Oct 13, 2023

I found that missed variables in en.yaml

  • changeLanguage: "Change language"
  • changeTheme: "Change theme"
  • searchPlaceholder: "Search..."

Adding default values ​​to en.yaml would be useful for translators.

@imfing
Copy link
Owner

imfing commented Oct 14, 2023

thank you, I'll take a look in a few days

@imfing
Copy link
Owner

imfing commented Oct 16, 2023

@iju707 Thanks for fixing this!
It's my bad not surfacing all these options properly.

@imfing imfing merged commit e42d018 into imfing:main Oct 16, 2023
4 checks passed
@iju707 iju707 deleted the fix-blog-readmore branch October 19, 2023 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants