Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove process.exit(1); for npm install. #79

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abetwothree
Copy link

This line is causing many people to stop from being able to deploy. (see this issue #78) Can this be changed to determine whether libpng-dev can be installed on the system and stop the process if it can be installed with a warning to the user to install libpng-dev, else just continue on installing npm packages? It seems that systems with a commad of apt-get have access to libpgn-dev.

This line is literally stopping the deployment of apps on systems where libpng-dev cannot be installed.

I am on CentOS and there is no libpng-dev package for that system.

Thank you!

This line is causing many people to stop from being able to deploy. (see this issue imagemin#78) Can this be changed to determine whether libpng-dev can be installed on the system and stop the process if it can be installed with a warning to the user to install libpng-dev, else just continue on installing npm packages? It seems that systems with a commad of apt-get have access to libpgn-dev. 

This line is literally stopping the deployment of apps on systems where libpng-dev cannot be installed.

I am on CentOS and there is no libpng-dev package for that system. 

Thank you!
@srinidhiprabandham
Copy link

Yes. I am having the same issue. A warning to the user would be better than this exiting. And we cannot reference a lower version of this as well. As this is a dependency of a dependency of a dependency.

Changes to this would be much appreciated.

@PHDorin
Copy link

PHDorin commented Mar 26, 2018

Is anyone looking into this, or do we have to come up with our own solutions? It is difficult for our project as it is an inner dependency, which means I can't solve it from code alone without committing node-modules and altering some code in there. Any help would be greatly appreciated.

@maturanomx
Copy link

Same problem. 6 months of this PR... Is a dead project?
Any one know an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants